Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make MatcherGenericBase copy constructor take const parameter. #2566

Merged
merged 1 commit into from
Nov 12, 2022

Conversation

mry792
Copy link
Contributor

@mry792 mry792 commented Nov 12, 2022

Description

Fix the copy constructor signature of MatcherGenericBase to take a const parameter. While C++ allows copy constructors taking non-const parameters, this is very atypical and blocks making copies of const objects.

GitHub Issues

@codecov
Copy link

codecov bot commented Nov 12, 2022

Codecov Report

Merging #2566 (926e361) into devel (41990e0) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##            devel    #2566   +/-   ##
=======================================
  Coverage   91.09%   91.09%           
=======================================
  Files         187      187           
  Lines        7622     7622           
=======================================
  Hits         6943     6943           
  Misses        679      679           

@horenmar
Copy link
Member

Thanks. AFAIK there is no reason for the use of plain ref there, just an oversight when the code was written.

@horenmar horenmar merged commit b980d40 into catchorg:devel Nov 12, 2022
@horenmar horenmar added the Tweak label Nov 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants